Bug 189356

Summary: [macOS] [WK2] Support changing attributes for selected text (text shadow, underline, strike-through)
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: HTML EditingAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, mitz, rniwa, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 189295    
Bug Blocks: 189383    
Attachments:
Description Flags
Blocked on webkit.org/b/189295
none
Rebase on trunk
none
Fix build for SDK < macOS 10.13 none

Description Wenson Hsieh 2018-09-06 10:14:46 PDT
...using controls on the NSFontPanel.
Comment 1 Radar WebKit Bug Importer 2018-09-06 10:15:43 PDT
<rdar://problem/44185674>
Comment 2 Wenson Hsieh 2018-09-06 11:49:33 PDT
Created attachment 349049 [details]
Blocked on webkit.org/b/189295
Comment 3 Ryosuke Niwa 2018-09-06 12:48:29 PDT
Could you update the patch for trunk?
Comment 4 Wenson Hsieh 2018-09-06 13:01:07 PDT
(In reply to Ryosuke Niwa from comment #3)
> Could you update the patch for trunk?

Yep, now that r235748 is in!
Comment 5 Wenson Hsieh 2018-09-06 13:01:13 PDT
Created attachment 349056 [details]
Rebase on trunk
Comment 6 Wenson Hsieh 2018-09-06 13:38:41 PDT
Created attachment 349064 [details]
Fix build for SDK < macOS 10.13
Comment 7 WebKit Commit Bot 2018-09-06 17:05:39 PDT
Comment on attachment 349064 [details]
Fix build for SDK < macOS 10.13

Clearing flags on attachment: 349064

Committed r235769: <https://trac.webkit.org/changeset/235769>
Comment 8 WebKit Commit Bot 2018-09-06 17:05:40 PDT
All reviewed patches have been landed.  Closing bug.