Bug 189345

Summary: [GTK] http/tests/media/clearkey/collect-webkit-media-session.html is timing out since added in r235429 "WebKitMediaSession should be GC collectable when its document is being stopped"
Product: WebKit Reporter: Miguel Gomez <magomez>
Component: WebKitGTKAssignee: Charlie Turner <cturner>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, commit-queue, cturner, youennf
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Miguel Gomez
Reported 2018-09-06 07:16:21 PDT
http/tests/media/clearkey/collect-webkit-media-session.html [ Timeout ] This is the text diff: --- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/media/clearkey/collect-webkit-media-session-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/media/clearkey/collect-webkit-media-session-actual.txt @@ -1,4 +1,2 @@ +FAIL: Timed out waiting for notifyDone to be called - -PASS Ensure that the frame's document get collected after being stopped while doing some webkit media session calls -
Attachments
Patch (1.81 KB, patch)
2019-12-19 15:59 PST, Charlie Turner 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Charlie Turner
Comment 1 2019-12-19 08:25:30 PST
I'm marking this as a resolved, since it is a legacy EME test (which we have deprecated), and also relies on a non-standard EXT-X-KEY URI scheme of "clearkey", which we will never support from GStreamer.
Charlie Turner
Comment 2 2019-12-19 15:59:09 PST
Reopening to attach new patch.
Charlie Turner
Comment 3 2019-12-19 15:59:12 PST
Created attachment 386159 [details] Patch
WebKit Commit Bot
Comment 4 2019-12-19 17:02:52 PST
Comment on attachment 386159 [details] Patch Clearing flags on attachment: 386159 Committed r253803: <https://trac.webkit.org/changeset/253803>
WebKit Commit Bot
Comment 5 2019-12-19 17:02:54 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.