Bug 189297

Summary: Remove unused bad_optional_access implementation.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, commit-queue, dbates, ddkilzer, ews-watchlist, fpizlo, jfbastien, keith_miller, msaboff, rmorisset, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch. none

Description Mark Lam 2018-09-04 21:47:54 PDT 
This is a speculative fix for resolving build errors arising from conflicting definitions of bad_optional_access when building WebKit with the latest clang.
Comment 1 Mark Lam 2018-09-04 21:52:11 PDT 
Created attachment 348893 [details]
proposed patch.
Comment 2 Mark Lam 2018-09-04 21:52:45 PDT 
Comment on attachment 348893 [details]
proposed patch.

I'll wait for EWS confirmation before landing.
Comment 3 David Kilzer (:ddkilzer) 2018-09-04 21:56:29 PDT 
Comment on attachment 348893 [details]
proposed patch.

r=me
Comment 4 Mark Lam 2018-09-05 00:26:17 PDT 
Comment on attachment 348893 [details]
proposed patch.

Thanks for the review.  Landing now.
Comment 5 WebKit Commit Bot 2018-09-05 00:52:24 PDT 
Comment on attachment 348893 [details]
proposed patch.

Clearing flags on attachment: 348893

Committed r235661: <https://trac.webkit.org/changeset/235661>
Comment 6 WebKit Commit Bot 2018-09-05 00:52:26 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-09-05 00:53:17 PDT 
<rdar://problem/44130109>