Bug 189287

Summary: Add generic entrypoint and run loop in TestWebKitAPI
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: Tools / TestsAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, commit-queue, ews-watchlist, lforschler, mcatanzaro, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Don Olmstead 2018-09-04 17:14:44 PDT
The JSCOnly implementation is really a generic implementation. Also main.cpp is the same as WPE's.
Comment 1 Don Olmstead 2018-09-04 17:57:05 PDT
Created attachment 348878 [details]
Patch
Comment 2 EWS Watchlist 2018-09-04 17:58:50 PDT
Attachment 348878 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/generic/UtilitiesGeneric.cpp:38:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Don Olmstead 2018-09-04 18:00:57 PDT
Created attachment 348880 [details]
Patch
Comment 4 Michael Catanzaro 2018-09-04 18:38:00 PDT
Comment on attachment 348880 [details]
Patch

Good
Comment 5 WebKit Commit Bot 2018-09-04 18:57:07 PDT
Comment on attachment 348880 [details]
Patch

Clearing flags on attachment: 348880

Committed r235654: <https://trac.webkit.org/changeset/235654>
Comment 6 WebKit Commit Bot 2018-09-04 18:57:08 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-09-04 18:58:19 PDT
<rdar://problem/44122651>