Bug 189274

Summary: JSC Build error when changing CPU type: offlineasm: No magic values found. Skipping assembly file generation
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, keith_miller, mark.lam, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
ppatch
saam: review+
Patch for Landing mark.lam: commit-queue-

Description Michael Saboff 2018-09-04 14:35:34 PDT 
If you successfully build JSC with:
$ Tools/Scripts/build-jsc --debug
and then try building with:
Tools/Scripts/build-jsc --debug ARCHS=i386
you'll get

offlineasm: No magic values found. Skipping assembly file generation.
Command /bin/sh failed with exit code 1

This is due to the build dependency checking seeing the derived file LLIntDesiredOffsets.h from the prior build and not generating one for the current architecture.
Comment 1 Michael Saboff 2018-09-04 14:36:07 PDT 
<rdar://problem/42900838>
Comment 2 Michael Saboff 2018-09-04 14:58:32 PDT 
Created attachment 348850 [details]
ppatch
Comment 3 Michael Saboff 2018-09-04 15:38:33 PDT 
Created attachment 348858 [details]
Patch for Landing
Comment 4 Michael Saboff 2018-09-04 17:51:26 PDT 
Inadvertently landed in Changeset r235636.

Change log landed in r235645.