| Summary: | Make the jsc shell print, printErr, and debug functions more robust. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||
| Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, msaboff, saam, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Mark Lam
2018-09-04 12:07:27 PDT
Created attachment 348836 [details]
proposed patch.
Comment on attachment 348836 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=348836&action=review > Source/JavaScriptCore/jsc.cpp:1030 > + scope.throwException(exec, createError(exec, "Source exhausted encountered during UTF8 conversion")); I should remove the "encountered" here. Comment on attachment 348836 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=348836&action=review r=me. >> Source/JavaScriptCore/jsc.cpp:1030 >> + scope.throwException(exec, createError(exec, "Source exhausted encountered during UTF8 conversion")); > > I should remove the "encountered" here. What does SourceExhausted error actually mean anyway? (In reply to Keith Miller from comment #3) > What does SourceExhausted error actually mean anyway? From convertUTF8ToUTF16() in UTF8.cpp, I think it means that a multi-byte encoding got cut off (i.e. missing bytes). Thanks for the review. Landed in r235627: <http://trac.webkit.org/r235627>. |