| Summary: | [Payment Request] Implement the MerchantValidationEvent constructor | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Andy Estes <aestes> |
| Component: | New Bugs | Assignee: | Andy Estes <aestes> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | achristensen, andersca, cdumez, commit-queue, dbates, eric.carlson, ews-watchlist, rniwa, sam, thorton, webkit-bug-importer, wenson_hsieh, youennf |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Attachments: | |||
|
Description
Andy Estes
2018-09-02 20:12:24 PDT
Created attachment 348754 [details]
Patch
Comment on attachment 348754 [details] Patch Attachment 348754 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9075179 Number of test failures exceeded the failure limit. Created attachment 348755 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Created attachment 348757 [details]
Patch
Comment on attachment 348757 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348757&action=review r=me > Source/WebCore/Modules/paymentrequest/MerchantValidationEvent.cpp:51 > MerchantValidationEvent::MerchantValidationEvent(const AtomicString& type, const URL& validationURL, PaymentRequest& paymentRequest) For your consideration, I suggest we change the data type of paymentRequest to a Ref<PaymentRequest>&& to convey that the caller is transferring ownership. (In reply to Daniel Bates from comment #5) > > Source/WebCore/Modules/paymentrequest/MerchantValidationEvent.cpp:51 > > MerchantValidationEvent::MerchantValidationEvent(const AtomicString& type, const URL& validationURL, PaymentRequest& paymentRequest) > > For your consideration, I suggest we change the data type of paymentRequest > to a Ref<PaymentRequest>&& to convey that the caller is transferring > ownership. Disregard this remark. Comment on attachment 348757 [details] Patch Attachment 348757 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9075793 New failing tests: imported/w3c/web-platform-tests/payment-request/payment-request-canmakepayment-method.https.html imported/w3c/web-platform-tests/payment-request/payment-request-abort-method.https.html Created attachment 348759 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 348757 [details] Patch Attachment 348757 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9075848 New failing tests: imported/w3c/web-platform-tests/payment-request/payment-request-canmakepayment-method.https.html imported/w3c/web-platform-tests/payment-request/payment-request-abort-method.https.html Created attachment 348760 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
Comment on attachment 348757 [details] Patch Attachment 348757 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9076439 New failing tests: imported/w3c/web-platform-tests/payment-request/payment-request-canmakepayment-method.https.html imported/w3c/web-platform-tests/payment-request/payment-request-abort-method.https.html Created attachment 348763 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
Created attachment 348773 [details]
Patch
Comment on attachment 348773 [details] Patch Clearing flags on attachment: 348773 Committed r235600: <https://trac.webkit.org/changeset/235600> All reviewed patches have been landed. Closing bug. |