Bug 189233

Summary:	[macOS] REGRESSION (r235398): Can’t run-safari: crash on launch in WKPageSetPageLoaderClient
Product:	WebKit	Reporter:	mitz
Component:	WebKit API	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED DUPLICATE
Severity:	Normal	CC:	achristensen, ap, fred.wang, thorton
Priority:	P1	Keywords:	Regression
Version:	Safari Technology Preview
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=188997 https://bugs.webkit.org/show_bug.cgi?id=189234

Description mitz 2018-09-02 09:19:14 PDT

Safari can’t run with a Debug build of r235583:

$ run-safari 
Starting SafariForWebKitDevelopment with DYLD_FRAMEWORK_PATH set to point to built WebKit in […]Debug.
ASSERTION FAILED: !m_client.didFinishDocumentLoadForFrame
/Projects/Safari/OpenSource/Source/WebKit/UIProcess/API/C/WKPage.cpp(1047) : WKPageSetPageLoaderClient(WKPageRef, const WKPageLoaderClientBase *)::LoaderClient::LoaderClient(const WKPageLoaderClientBase *)
1   0x10f428da9 WTFCrash
2   0x11400d3fb WTFCrashWithInfo(int, char const*, char const*, int)
3   0x115196374 WKPageSetPageLoaderClient::LoaderClient::LoaderClient(WKPageLoaderClientBase const*)
4   0x1151962bd WKPageSetPageLoaderClient::LoaderClient::LoaderClient(WKPageLoaderClientBase const*)
5   0x11518f95d WKPageSetPageLoaderClient
6   0x7fff573f0e8e Safari::WK::Page::setPageLoaderClient(Safari::WK::PageLoaderClient*) const
[…]

Comment 1 mitz 2018-09-02 09:21:32 PDT

This is with Safari from macOS High Sierra 10.13.6.

Comment 2 mitz 2018-09-02 10:00:52 PDT

Release builds crash as well:

0   com.apple.WebKit              	0x000000010c86b313 WTFCrashWithInfo(int, char const*, char const*, int) + 19 (Assertions.h:551)
1   com.apple.WebKit              	0x000000010cc4995b WKPageSetPageLoaderClient + 680 (Assertions.h:570)
2   com.apple.Safari.framework    	0x00007fff573f0e8e Safari::WK::Page::setPageLoaderClient(Safari::WK::PageLoaderClient*) const + 56

Comment 3 mitz 2018-09-02 10:12:22 PDT

Caused by <https://trac.webkit.org/r235398>, the change made for bug 188997.

Comment 4 Tim Horton 2018-09-02 15:32:57 PDT

Is this the same as https://bugs.webkit.org/show_bug.cgi?id=189190

Comment 5 mitz 2018-09-02 15:34:25 PDT

(In reply to Tim Horton from comment #4)
> Is this the same as https://bugs.webkit.org/show_bug.cgi?id=189190

Seems so.

Comment 6 Frédéric Wang (:fredw) 2018-09-03 01:34:19 PDT


*** This bug has been marked as a duplicate of bug 189190 ***