| Summary: | Rename FilterEffectRenderer to CSSFilter | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, dino, sabouhallawa, sam, simon.fraser, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Simon Fraser (smfr)
2018-09-01 16:45:20 PDT
Created attachment 348720 [details]
Patch
Created attachment 348721 [details]
Patch
Created attachment 348722 [details]
Patch
Comment on attachment 348722 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348722&action=review > Source/WebCore/ChangeLog:22 > + * rendering/CSSFilter.cpp: Copied from Source/WebCore/rendering/FilterEffectRenderer.cpp. Seems a little weird to have something prefixed with CSS in the rendering directory (I think all the other CSS prefixed classes/files are in the css directory). Is there a way we can avoid using CSS as the prefix? Yeah, I had the same thought. It could be StyleFilter. (In reply to Simon Fraser (smfr) from comment #5) > Yeah, I had the same thought. It could be StyleFilter. I think of the two choices, CSSFilter is clearer. Comment on attachment 348722 [details] Patch Clearing flags on attachment: 348722 Committed r235586: <https://trac.webkit.org/changeset/235586> All reviewed patches have been landed. Closing bug. |