| Summary: | IDBRequest and IDBCursor should not hold strong references to JSValue | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||||||||||
| Component: | WebCore Misc. | Assignee: | youenn fablet <youennf> | ||||||||||||||||||
| Status: | RESOLVED CONFIGURATION CHANGED | ||||||||||||||||||||
| Severity: | Normal | CC: | achristensen, alecflett, beidson, cdumez, esprehn+autocc, ews-watchlist, jsbell, kondapallykalyan, rniwa, simon.fraser | ||||||||||||||||||
| Priority: | P2 | ||||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||
|
Description
youenn fablet
2018-08-31 11:07:53 PDT
Created attachment 348654 [details]
Patch
Created attachment 348669 [details]
Patch
Comment on attachment 348669 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348669&action=review > Source/WebCore/Modules/indexeddb/IDBCursor.h:104 > // FIXME: The following uses of JSC::Strong are incorrect and can lead to storage leaks > // due to reference cycles; we should use JSValueInWrappedObject instead. This comment should be removed. Comment on attachment 348669 [details] Patch Attachment 348669 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9055070 New failing tests: imported/w3c/web-platform-tests/IndexedDB/interleaved-cursors-small.html imported/w3c/web-platform-tests/IndexedDB/interleaved-cursors-large.html Created attachment 348684 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 348669 [details] Patch Attachment 348669 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9055166 New failing tests: imported/w3c/web-platform-tests/IndexedDB/interleaved-cursors-small.html imported/w3c/web-platform-tests/IndexedDB/interleaved-cursors-large.html Created attachment 348692 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
Created attachment 348707 [details]
Patch
Created attachment 348712 [details]
Patch
Comment on attachment 348712 [details] Patch Attachment 348712 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9062021 New failing tests: imported/w3c/web-platform-tests/IndexedDB/interleaved-cursors-small.html Created attachment 348714 [details]
Archive of layout-test-results from ews100 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 348826 [details]
Patch
|