| Summary: | Assertion hit in ~CompletionHandler() from ~WebFrame() | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
| Component: | WebKit2 | Assignee: | Chris Dumez <cdumez> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | achristensen, commit-queue, dbates, ews-watchlist, ggaren, japhet, rniwa, ryanhaddad, webkit-bug-importer, youennf | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Chris Dumez
2018-08-31 10:36:34 PDT
Created attachment 348649 [details]
Patch
Comment on attachment 348649 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348649&action=review > Source/WebCore/loader/EmptyClients.cpp:461 > +void EmptyFrameLoaderClient::dispatchWillSubmitForm(FormState&, CompletionHandler<void(void)>&& completionHandler) s/void(void)/void()/ here and below? > Source/WebKit/WebProcess/WebPage/WebFrame.cpp:252 > + completionHandler(); Should we be safe here and move m_willSubmitFormCompletionHandlers.values in a local variable as well. Then no need to clear it anymore below. Created attachment 348652 [details]
Patch
Comment on attachment 348652 [details]
Patch
Hooray! CompletionHandlers found and fixed a loading bug!
Comment on attachment 348652 [details] Patch Clearing flags on attachment: 348652 Committed r235562: <https://trac.webkit.org/changeset/235562> All reviewed patches have been landed. Closing bug. This change broke the Windows build: C:\cygwin\home\buildbot\slave\win-release\build\Source\WebKitLegacy\win\WebCoreSupport\WebFrameLoaderClient.cpp(626): error C3848: expression having type 'const WTF::CompletionHandler<void (void)>' would lose some const-volatile qualifiers in order to call 'void WTF::CompletionHandler<void (void)>::operator ()(void)' [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/11591/steps/compile-webkit/logs/stdio (In reply to Ryan Haddad from comment #8) > This change broke the Windows build: > C:\cygwin\home\buildbot\slave\win- > release\build\Source\WebKitLegacy\win\WebCoreSupport\WebFrameLoaderClient. > cpp(626): error C3848: expression having type 'const > WTF::CompletionHandler<void (void)>' would lose some const-volatile > qualifiers in order to call 'void WTF::CompletionHandler<void > (void)>::operator ()(void)' > [C:\cygwin\home\buildbot\slave\win- > release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] > > https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/ > 11591/steps/compile-webkit/logs/stdio Thanks, will fix now. (In reply to Chris Dumez from comment #9) > (In reply to Ryan Haddad from comment #8) > > This change broke the Windows build: > > C:\cygwin\home\buildbot\slave\win- > > release\build\Source\WebKitLegacy\win\WebCoreSupport\WebFrameLoaderClient. > > cpp(626): error C3848: expression having type 'const > > WTF::CompletionHandler<void (void)>' would lose some const-volatile > > qualifiers in order to call 'void WTF::CompletionHandler<void > > (void)>::operator ()(void)' > > [C:\cygwin\home\buildbot\slave\win- > > release\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] > > > > https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/ > > 11591/steps/compile-webkit/logs/stdio > > Thanks, will fix now. Should be fixed as of <https://trac.webkit.org/changeset/235566>. |