Bug 189197

Summary: [JSC] [Armv7] implement patchableBranch8()
Product: WebKit Reporter: Guillaume Emont <guijemont>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Guillaume Emont
Reported 2018-08-31 10:00:01 PDT
The build is broken for Armv7 since r235517 because it needs an implementation of that method.
Attachments
Patch (1.58 KB, patch)
2018-08-31 10:17 PDT, Guillaume Emont 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Guillaume Emont
Comment 1 2018-08-31 10:17:45 PDT
Created attachment 348646 [details] Patch Tentative implemention, currently running tests on a device to check that it does not break anything.
Guillaume Emont
Comment 2 2018-08-31 10:18:17 PDT
(In reply to Guillaume Emont from comment #1) > Created attachment 348646 [details] > Patch > > Tentative implemention, currently running tests on a device to check that it > does not break anything. (Copy-pasted from the Arm64 implementation, but that should do).
Mark Lam
Comment 3 2018-08-31 10:26:20 PDT
I already landed a build fix for this in r235557: <https://trac.webkit.org/r235557>. Does that not work?
Guillaume Emont
Comment 4 2018-08-31 10:28:13 PDT
(In reply to Mark Lam from comment #3) > I already landed a build fix for this in r235557: > <https://trac.webkit.org/r235557>. Does that not work? Yes, that should work, I had not seen it yet. Sorry for the noise.
Radar WebKit Bug Importer
Comment 5 2018-08-31 10:29:17 PDT
<rdar://problem/43945560>
Note You need to log in before you can comment on or make changes to this bug.