| Summary: | Fix exception check accounting in constructJSWebAssemblyCompileError(). | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||||
| Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, ews-watchlist, keith_miller, msaboff, realdawei, saam, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Mark Lam
2018-08-31 00:06:21 PDT
Created attachment 348616 [details]
proposed patch.
Comment on attachment 348616 [details]
proposed patch.
r=me
Comment on attachment 348616 [details] proposed patch. Clearing flags on attachment: 348616 Committed r235558: <https://trac.webkit.org/changeset/235558> All reviewed patches have been landed. Closing bug. Comment on attachment 348616 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=348616&action=review > Source/JavaScriptCore/wasm/js/JSWebAssemblyModule.cpp:51 > + auto* error = JSWebAssemblyCompileError::create(exec, vm, structure->globalObject()->WebAssemblyCompileErrorStructure(), result.error()); Why would creating the exception throw an exception? (In reply to Saam Barati from comment #5) > Comment on attachment 348616 [details] > proposed patch. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=348616&action=review > > > Source/JavaScriptCore/wasm/js/JSWebAssemblyModule.cpp:51 > > + auto* error = JSWebAssemblyCompileError::create(exec, vm, structure->globalObject()->WebAssemblyCompileErrorStructure(), result.error()); > > Why would creating the exception throw an exception? See "static JSWebAssemblyCompileError* create(ExecState* exec, VM& vm, Structure* structure, JSValue message)" in JSWebAssemblyCompileError.h. It calls message.toWTFString(exec) which can throw. (In reply to Mark Lam from comment #6) > (In reply to Saam Barati from comment #5) > > Comment on attachment 348616 [details] > > proposed patch. > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=348616&action=review > > > > > Source/JavaScriptCore/wasm/js/JSWebAssemblyModule.cpp:51 > > > + auto* error = JSWebAssemblyCompileError::create(exec, vm, structure->globalObject()->WebAssemblyCompileErrorStructure(), result.error()); > > > > Why would creating the exception throw an exception? > > See "static JSWebAssemblyCompileError* create(ExecState* exec, VM& vm, > Structure* structure, JSValue message)" in JSWebAssemblyCompileError.h. It > calls message.toWTFString(exec) which can throw. Ok, makes sense. Reopening to attach new patch. Created attachment 348827 [details]
Patch
Comment on attachment 348827 [details] Patch Clearing flags on attachment: 348827 Committed r235624: <https://trac.webkit.org/changeset/235624> All reviewed patches have been landed. Closing bug. |