| Summary: | Move stats gathering out of LibWebRTCMediaEndpoint | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | alex, commit-queue, eric.carlson, ews-watchlist, jonlee, webkit-bug-importer, youennf | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
youenn fablet
2018-08-30 21:17:35 PDT
Created attachment 348598 [details]
Patch
Attachment 348598 [details] did not pass style-queue:
ERROR: Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCStatsCollector.h:34: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 348602 [details]
Patch
Attachment 348602 [details] did not pass style-queue:
ERROR: Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCStatsCollector.h:35: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 348602 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348602&action=review LGTM > Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCStatsCollector.cpp:2 > + * Copyright (C) 2017 Apple Inc. All rights reserved. 2018 > Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCStatsCollector.h:2 > + * Copyright (C) 2017 Apple Inc. All rights reserved. 2018 Comment on attachment 348602 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348602&action=review > Source/WebCore/ChangeLog:13 > + * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp: Please update the copyright years on these files. Created attachment 348670 [details]
Patch for landing
Attachment 348670 [details] did not pass style-queue:
ERROR: Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCStatsCollector.h:35: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 9 files
If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to youenn fablet from comment #7) > Created attachment 348670 [details] > Patch for landing Thanks for the review, I updated copyrights accordingly. Comment on attachment 348670 [details] Patch for landing Clearing flags on attachment: 348670 Committed r235576: <https://trac.webkit.org/changeset/235576> All reviewed patches have been landed. Closing bug. |