| Summary: | REGRESSION(r235489): fast/dom/navigator-detached-no-crash.html crashes under Navigator::share | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Olivia Barnett <obarnett> | ||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, ddkilzer, ews-watchlist, thorton, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 171100 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Olivia Barnett
2018-08-30 13:34:38 PDT
Created attachment 348537 [details]
Patch
Attachment 348537 [details] did not pass style-queue:
ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 348537 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348537&action=review > Source/WebCore/ChangeLog:8 > + No new tests (OOPS!). Get this outta here. Maybe "No new tests; fixing a failing existing test." Created attachment 348540 [details]
Patch
Comment on attachment 348540 [details] Patch Clearing flags on attachment: 348540 Committed r235524: <https://trac.webkit.org/changeset/235524> All reviewed patches have been landed. Closing bug. |