Bug 189149

Summary: [ConnectionUnix] Shrink sizeof AttachmentInfo by reordering members
Product: WebKit Reporter: Yoshiaki Jitsukawa <yoshiaki.jitsukawa>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, don.olmstead, mcatanzaro, webkit-bug-importer, yoshiaki.jitsukawa, ysuzuki, zan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Yoshiaki Jitsukawa
Reported 2018-08-30 00:15:51 PDT
Shrink sizeof AttachmentInfo by reordering members. It is not possible to pack AttachmentInfo up to attachmentMaxAmount(255) within messageMaxSize(4096 bytes).
Attachments
Patch (1.70 KB, patch)
2018-08-30 00:26 PDT, Yoshiaki Jitsukawa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yoshiaki Jitsukawa
Comment 1 2018-08-30 00:26:11 PDT
Created attachment 348489 [details] Patch
Michael Catanzaro
Comment 2 2018-08-30 06:35:23 PDT
Comment on attachment 348489 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348489&action=review > Source/WebKit/Platform/IPC/unix/ConnectionUnix.cpp:93 > +static_assert(sizeof(MessageInfo) + sizeof(AttachmentInfo) * attachmentMaxAmount <= messageMaxSize, "messageMaxSize is too small."); Oh wow, good catch
WebKit Commit Bot
Comment 3 2018-08-30 07:01:56 PDT
Comment on attachment 348489 [details] Patch Clearing flags on attachment: 348489 Committed r235499: <https://trac.webkit.org/changeset/235499>
WebKit Commit Bot
Comment 4 2018-08-30 07:01:57 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2018-08-30 07:03:25 PDT
<rdar://problem/43884387>
Note You need to log in before you can comment on or make changes to this bug.