| Summary: | Add assignedElements to HTMLSlotElement | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||
| Component: | DOM | Assignee: | Ryosuke Niwa <rniwa> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | annevk, cdumez, darin, esprehn+autocc, ews-watchlist, ggaren, gyuyoung.kim, koivisto, kondapallykalyan, sam, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 148695 | ||||||
| Attachments: |
|
||||||
|
Description
Ryosuke Niwa
2018-08-29 22:30:09 PDT
Created attachment 348485 [details]
Adds the method
Comment on attachment 348485 [details] Adds the method View in context: https://bugs.webkit.org/attachment.cgi?id=348485&action=review > Source/WebCore/html/HTMLSlotElement.h:43 > Vector<Node*> assignedNodes(const AssignedNodesOptions&) const; > + Vector<Ref<Element>> assignedElements(const AssignedNodesOptions&) const; Why does assignedNodes return Node* instead of Ref<Node>? Why not make the two consistent? (In reply to Darin Adler from comment #3) > Comment on attachment 348485 [details] > Adds the method > > View in context: > https://bugs.webkit.org/attachment.cgi?id=348485&action=review > > > Source/WebCore/html/HTMLSlotElement.h:43 > > Vector<Node*> assignedNodes(const AssignedNodesOptions&) const; > > + Vector<Ref<Element>> assignedElements(const AssignedNodesOptions&) const; > > Why does assignedNodes return Node* instead of Ref<Node>? Why not make the > two consistent? That's a good point. Since we're making a copy in both cases, we should probably always return Vector<Ref<~>>. Will fix before landing. Committed r235535: <https://trac.webkit.org/changeset/235535> *** Bug 180908 has been marked as a duplicate of this bug. *** |