| Summary: | [LFC][Margins] Add non-computed horizontal margins to DisplayBox | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
zalan
2018-08-29 19:54:21 PDT
Created attachment 348473 [details]
Patch
Created attachment 348482 [details]
Patch
Comment on attachment 348482 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348482&action=review > Source/WebCore/layout/blockformatting/BlockFormattingContextGeometry.cpp:241 > + return WidthAndMargin { *width, { *marginLeft, *marginRight }, { nonComputedMarginLeft, nonComputedMarginRight } }; return { *width, { *marginLeft, *marginRight }, { nonComputedMarginLeft, nonComputedMarginRight } } ; should work too? Comment on attachment 348482 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348482&action=review > Source/WebCore/layout/FormattingContextGeometry.cpp:420 > + return { *left, *right, { *width, { *marginLeft, *marginRight }, {nonComputedMarginLeft, nonComputedMarginRight } } }; Missing space before nonComputedMarginLeft Committed r235501: <https://trac.webkit.org/changeset/235501> |