Bug 189137

Summary: grid track size should reject unitless length
Product: WebKit Reporter: Eric Willigers <ericwilligers>
Component: CSSAssignee: Rob Buis <rbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jfernandez, macpherson, menard, rbuis, rego, simon.fraser, svillar, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: Safari 11   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Eric Willigers 2018-08-29 18:22:35 PDT 
In quirks mode, Safari currently accepts unitless lengths for the following properties:
- grid-auto-columns
- grid-auto-rows
- grid-template-columns
- grid-template-rows

This is contrary to spec. 
https://quirks.spec.whatwg.org/#the-unitless-length-quirk
https://drafts.csswg.org/css-grid/#track-sizing
Comment 1 Eric Willigers 2018-08-29 18:26:39 PDT 
background-size should also reject unitless length.
Comment 2 Eric Willigers 2018-10-25 23:34:51 PDT 
See also https://bugs.webkit.org/show_bug.cgi?id=104805
Comment 3 Rob Buis 2021-05-21 00:10:03 PDT 
Created attachment 429269 [details]
Patch
Comment 4 Rob Buis 2021-05-21 01:45:07 PDT 
Created attachment 429272 [details]
Patch
Comment 5 Sergio Villar Senin 2021-05-21 08:51:52 PDT 
Comment on attachment 429272 [details]
Patch

Nice!
Comment 6 EWS 2021-05-21 10:16:28 PDT 
Committed r277868 (238008@main): <https://commits.webkit.org/238008@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429272 [details].
Comment 7 Radar WebKit Bug Importer 2021-05-21 10:17:21 PDT 
<rdar://problem/78316259>