| Summary: | [WHLSL] Test row-majorness of matrices | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||||||||
| Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | commit-queue, dino, ews-feeder, fpizlo, rmorisset, tdenney, webkit-bug-importer | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Bug Depends on: | |||||||||||||||
| Bug Blocks: | 176199, 189099 | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Myles C. Maxfield
2018-08-29 15:32:29 PDT
Created attachment 348440 [details]
Patch
Comment on attachment 348440 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348440&action=review > Tools/WebGPUShadingLanguageRI/Test.js:5540 > + let result = callFunction(program, "foo", []); It would be better to have separate functions that we call to check each element, e.g. float foo00() { return foo()[0][0]; } checkFloat(program, callFunction(program, “foo00”, []), 17 * 2 + 31 * 3 + 47 * 5) as this will make it easier to tie into the Metal test suite. Created attachment 348451 [details]
Patch
Comment on attachment 348451 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348451&action=review > Tools/WebGPUShadingLanguageRI/Test.html:155 > + var tester = doTest(/matrixMultiplication/); This shouldn’t be here. Created attachment 348452 [details]
Patch
Comment on attachment 348452 [details]
Patch
r=me too
Comment on attachment 348452 [details] Patch Rejecting attachment 348452 [details] from review queue. tdenney@apple.com does not have reviewer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights. Created attachment 348457 [details]
Patch for committing
Created attachment 348458 [details]
Patch for committing
Comment on attachment 348458 [details] Patch for committing Clearing flags on attachment: 348458 Committed r235493: <https://trac.webkit.org/changeset/235493> All reviewed patches have been landed. Closing bug. Migrated to https://github.com/gpuweb/WHLSL/issues/71 |