Bug 189096

Summary: Enable USE_MEDIAREMOTE on iOS
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: MediaAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, ews-watchlist, jonlee, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-watchlist: commit-queue-
Archive of layout-test-results from ews121 for ios-simulator-wk2
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch for landing
none
Patch for landing
none
Patch for landing
none
Patch for landing
none
Patch for landing none

Description Jer Noble 2018-08-29 14:01:37 PDT 
Enable USE_MEDIASOURCE on iOS
Comment 1 Jer Noble 2018-08-29 14:09:50 PDT 
Created attachment 348430 [details]
Patch
Comment 2 EWS Watchlist 2018-08-29 16:19:51 PDT 
Comment on attachment 348430 [details]
Patch

Attachment 348430 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9027334

New failing tests:
media/video-main-content-deny-obscured.html
media/remove-video-best-media-element-in-main-frame-crash.html
Comment 3 EWS Watchlist 2018-08-29 16:19:52 PDT 
Created attachment 348444 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4
Comment 4 Jer Noble 2018-08-29 16:51:17 PDT 
Created attachment 348450 [details]
Patch
Comment 5 Jon Lee 2018-08-30 08:49:14 PDT 
Comment on attachment 348450 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348450&action=review

> Source/WTF/ChangeLog:3
> +        Enable USE_MEDIASOURCE on iOS

Do you mean media remote?
Comment 6 Jer Noble 2018-08-30 12:36:17 PDT 
(In reply to Jon Lee from comment #5)
> Comment on attachment 348450 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=348450&action=review
> 
> > Source/WTF/ChangeLog:3
> > +        Enable USE_MEDIASOURCE on iOS
> 
> Do you mean media remote?

Whoops, Freudian slip.
Comment 7 Jer Noble 2018-08-30 12:38:42 PDT 
Created attachment 348530 [details]
Patch
Comment 8 Jer Noble 2018-08-30 14:35:03 PDT 
Created attachment 348553 [details]
Patch
Comment 9 Jer Noble 2018-08-31 10:13:07 PDT 
Created attachment 348644 [details]
Patch
Comment 10 Jer Noble 2018-08-31 10:15:41 PDT 
Created attachment 348645 [details]
Patch
Comment 11 Jer Noble 2018-09-10 10:00:46 PDT 
Created attachment 349316 [details]
Patch
Comment 12 Jer Noble 2018-09-11 10:30:43 PDT 
Created attachment 349408 [details]
Patch
Comment 13 Jer Noble 2018-09-11 13:42:10 PDT 
Created attachment 349442 [details]
Patch
Comment 14 Jer Noble 2018-09-11 13:48:38 PDT 
Created attachment 349446 [details]
Patch
Comment 15 Eric Carlson 2018-09-12 16:36:33 PDT 
Comment on attachment 349446 [details]
Patch

++NLOC!
Comment 16 WebKit Commit Bot 2018-09-13 15:19:47 PDT 
Comment on attachment 349446 [details]
Patch

Clearing flags on attachment: 349446

Committed r235990: <https://trac.webkit.org/changeset/235990>
Comment 17 WebKit Commit Bot 2018-09-13 15:19:49 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 18 Radar WebKit Bug Importer 2018-09-13 15:22:13 PDT 
<rdar://problem/44434472>
Comment 19 Ryan Haddad 2018-09-13 16:41:08 PDT 
The following API tests are timing out on iOS Simulator after this change:

    TestWebKitAPI.NowPlayingTest.VideoElementWithMutedAudio
    TestWebKitAPI.NowPlayingTest.VideoElementWithoutAudioPlayWithUserGesture
    TestWebKitAPI.NowPlayingTest.VideoElementWithoutAudio
    TestWebKitAPI.NowPlayingTest.AudioElement
    TestWebKitAPI.NowPlayingTest.VideoElementWithMutedAudioUnmutedWithUserGesture

https://build.webkit.org/builders/Apple%20iOS%2011%20Simulator%20Release%20WK2%20(Tests)/builds/7409
Comment 20 Ryan Haddad 2018-09-14 11:17:50 PDT 
Reverted r235990 for reason:

Introduced TestWebKitAPI.NowPlayingTest timeouts on iOS

Committed r236011: <https://trac.webkit.org/changeset/236011>
Comment 21 Jer Noble 2018-09-17 10:37:05 PDT 
Created attachment 349896 [details]
Patch for landing
Comment 22 Jer Noble 2018-09-17 10:37:20 PDT 
Created attachment 349897 [details]
Patch for landing
Comment 23 WebKit Commit Bot 2018-09-17 10:38:44 PDT 
Comment on attachment 349897 [details]
Patch for landing

Rejecting attachment 349897 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 349897, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WTF/ChangeLog contains OOPS!.

Full output: https://webkit-queues.webkit.org/results/9244349
Comment 24 Jer Noble 2018-09-17 10:40:33 PDT 
Created attachment 349898 [details]
Patch for landing
Comment 25 WebKit Commit Bot 2018-09-17 10:41:34 PDT 
Comment on attachment 349898 [details]
Patch for landing

Rejecting attachment 349898 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 349898, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WTF/ChangeLog contains OOPS!.

Full output: https://webkit-queues.webkit.org/results/9244370
Comment 26 Jer Noble 2018-09-17 10:51:37 PDT 
Created attachment 349904 [details]
Patch for landing
Comment 27 Jer Noble 2018-09-17 11:17:46 PDT 
Created attachment 349909 [details]
Patch for landing
Comment 28 WebKit Commit Bot 2018-09-17 11:58:01 PDT 
Comment on attachment 349909 [details]
Patch for landing

Clearing flags on attachment: 349909

Committed r236077: <https://trac.webkit.org/changeset/236077>
Comment 29 WebKit Commit Bot 2018-09-17 11:58:03 PDT 
All reviewed patches have been landed.  Closing bug.