Bug 189071

Summary: [CMake] Use CMake's FindFreetype
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: CMakeAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, commit-queue, ews-watchlist, mcatanzaro, webkit-bug-importer
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Don Olmstead 2018-08-28 17:45:17 PDT 
Back in https://bugs.webkit.org/show_bug.cgi?id=130150 a FreeType2.cmake file was introduced. This seems to be completely legacy.
Comment 1 Don Olmstead 2018-08-28 17:49:29 PDT 
Created attachment 348368 [details]
Patch

Let's see if GTK and WPE are happy with this change
Comment 2 EWS Watchlist 2018-08-28 17:52:02 PDT 
Attachment 348368 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Don Olmstead 2018-08-28 17:56:20 PDT 
Created attachment 348369 [details]
Patch

Make style checker happy
Comment 4 WebKit Commit Bot 2018-08-28 20:58:39 PDT 
Comment on attachment 348369 [details]
Patch

Clearing flags on attachment: 348369

Committed r235454: <https://trac.webkit.org/changeset/235454>
Comment 5 WebKit Commit Bot 2018-08-28 20:58:41 PDT 
All reviewed patches have been landed.  Closing bug.