Bug 189056

Summary: [Curl][WebKit] Bugfix on redirect.
Product: WebKit Reporter: Basuke Suzuki <Basuke.Suzuki>
Component: PlatformAssignee: Basuke Suzuki <Basuke.Suzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, Basuke.Suzuki, commit-queue, don.olmstead, Hironori.Fujii, webkit-bug-importer, youennf
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
PATCH
achristensen: review+, achristensen: commit-queue-
fix none

Description Basuke Suzuki 2018-08-28 13:38:50 PDT
Forget to call request update method.
Comment 1 Basuke Suzuki 2018-08-28 13:43:07 PDT
Created attachment 348335 [details]
PATCH
Comment 2 Don Olmstead 2018-08-29 13:15:08 PDT
Comment on attachment 348335 [details]
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=348335&action=review

LGTM from my informal review.

> Source/WebKit/NetworkProcess/NetworkLoad.cpp:154
> +#elif USE(SOUP) || USE(CURL)

Minor nit. Should this just be an #else?
Comment 3 Alex Christensen 2018-08-29 18:55:51 PDT
Comment on attachment 348335 [details]
PATCH

Yep
Comment 4 Basuke Suzuki 2018-08-30 10:34:59 PDT
Created attachment 348504 [details]
fix
Comment 5 Basuke Suzuki 2018-08-30 10:36:34 PDT
Thanks. I forgot we can forget about AppleWin in this component.
Comment 6 WebKit Commit Bot 2018-08-30 11:13:09 PDT
Comment on attachment 348504 [details]
fix

Clearing flags on attachment: 348504

Committed r235510: <https://trac.webkit.org/changeset/235510>
Comment 7 WebKit Commit Bot 2018-08-30 11:13:10 PDT
All reviewed patches have been landed.  Closing bug.