| Summary: | [LFC][Floating] Remove redundant FloatAvoider functions. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
zalan
2018-08-27 16:39:53 PDT
Created attachment 348239 [details]
Patch
Comment on attachment 348239 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348239&action=review > Source/WebCore/layout/floats/FloatAvoider.h:64 > + void resetHorizontalConstraint(); Some of these are singulars like here "Constraint". > Source/WebCore/layout/floats/FloatingContext.cpp:71 > + FloatAvoider::HorizontalConstraints horizontalConstraints() const; And some are plural. Is there some logic to this? Comment on attachment 348239 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348239&action=review > Source/WebCore/layout/floats/FloatingContext.cpp:228 > + floatAvoider.setHorizontalConstraints(floats.horizontalConstraints()); > + floatAvoider.setVerticalConstraint(floats.verticalPosition()); It looks strange that the second one is reading floats.verticalPosition instead of floats.verticalConstraint. But maybe it makes sense? Committed r235423: <https://trac.webkit.org/changeset/235423> (In reply to Antti Koivisto from comment #2) > Comment on attachment 348239 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=348239&action=review > > > Source/WebCore/layout/floats/FloatAvoider.h:64 > > + void resetHorizontalConstraint(); > > Some of these are singulars like here "Constraint". > > > Source/WebCore/layout/floats/FloatingContext.cpp:71 > > + FloatAvoider::HorizontalConstraints horizontalConstraints() const; > > And some are plural. Is there some logic to this? Fixed. No logic, oversight. (In reply to Antti Koivisto from comment #3) > Comment on attachment 348239 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=348239&action=review > > > Source/WebCore/layout/floats/FloatingContext.cpp:228 > > + floatAvoider.setHorizontalConstraints(floats.horizontalConstraints()); > > + floatAvoider.setVerticalConstraint(floats.verticalPosition()); > > It looks strange that the second one is reading floats.verticalPosition > instead of floats.verticalConstraint. But maybe it makes sense? Fixed. |