Bug 189019

Summary: Use enum classes for AlternativeTextType and ReasonForDismissingAlternativeText
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: NEW ---    
Severity: Normal CC: ews-watchlist, rniwa, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
simon.fraser: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews106 for mac-sierra-wk2
none
Archive of layout-test-results from ews122 for ios-simulator-wk2 none

Description Alex Christensen 2018-08-27 15:36:28 PDT
Use enum classes for AlternativeTextType and ReasonForDismissingAlternativeText
Comment 1 Alex Christensen 2018-08-27 15:37:26 PDT
Created attachment 348218 [details]
Patch
Comment 2 EWS Watchlist 2018-08-27 15:39:43 PDT
Attachment 348218 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alex Christensen 2018-09-12 14:37:28 PDT
Created attachment 349583 [details]
Patch
Comment 4 EWS Watchlist 2018-09-12 20:34:50 PDT
Comment on attachment 349583 [details]
Patch

Attachment 349583 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9198536

New failing tests:
fast/animation/css-animation-resuming-when-visible-with-style-change2.html
Comment 5 EWS Watchlist 2018-09-12 20:34:52 PDT
Created attachment 349619 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 6 EWS Watchlist 2018-09-13 02:39:22 PDT
Comment on attachment 349583 [details]
Patch

Attachment 349583 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9200985

New failing tests:
fast/animation/css-animation-resuming-when-visible-with-style-change2.html
Comment 7 EWS Watchlist 2018-09-13 02:39:23 PDT
Created attachment 349647 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4
Comment 8 Simon Fraser (smfr) 2018-09-13 11:37:09 PDT
Comment on attachment 349583 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349583&action=review

> Source/WebCore/page/AlternativeTextClient.h:35
> +enum class ReasonForDismissingAlternativeText {

: uint8_t ?

> Source/WebCore/page/AlternativeTextClient.h:41
> +enum class AlternativeTextType {

: uint8_t ?
Comment 9 Alex Christensen 2018-09-13 11:54:13 PDT
(In reply to Simon Fraser (smfr) from comment #8)
> : uint8_t ?
Unfortunately that's not supported with enum types that are encoded and decoded yet.  We should add that to the *.messages.in grammar, though.