Bug 189014

Summary: [WHLSL] The parser is too slow
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: WebGPUAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, fpizlo, rmorisset, saam, tdenney, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 176199, 189202    
Attachments:
Description Flags
WIP
none
first draft
none
Second draft
none
Removes try/catch
none
Patch
none
Patch
none
Patch none

Description Myles C. Maxfield 2018-08-27 15:18:46 PDT 
It takes 2.5 hours to compile the standard library. 95% of the time is spent parsing.
Comment 1 Myles C. Maxfield 2018-08-27 15:21:28 PDT 

*** This bug has been marked as a duplicate of bug 188517 ***
Comment 2 Myles C. Maxfield 2018-08-28 15:54:30 PDT 
Reopening
Comment 3 Myles C. Maxfield 2018-09-04 19:41:52 PDT 
Created attachment 348887 [details]
WIP
Comment 4 Myles C. Maxfield 2018-09-05 11:42:55 PDT 
Created attachment 348951 [details]
first draft
Comment 5 Myles C. Maxfield 2018-09-05 13:06:32 PDT 
Created attachment 348955 [details]
Second draft
Comment 6 Myles C. Maxfield 2018-09-05 15:12:22 PDT 
Created attachment 348970 [details]
Removes try/catch
Comment 7 Myles C. Maxfield 2018-09-05 17:27:41 PDT 
Created attachment 348985 [details]
Patch
Comment 8 Thomas Denney 2018-09-05 17:34:54 PDT 
Comment on attachment 348985 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348985&action=review

> Tools/WebGPUShadingLanguageRI/Lexer.js:45
> +        }

Weird characters here.
Comment 9 Myles C. Maxfield 2018-09-05 19:00:45 PDT 
Created attachment 348993 [details]
Patch
Comment 10 Myles C. Maxfield 2018-09-05 19:10:37 PDT 
Created attachment 348994 [details]
Patch
Comment 11 WebKit Commit Bot 2018-09-06 09:01:13 PDT 
Comment on attachment 348994 [details]
Patch

Clearing flags on attachment: 348994

Committed r235738: <https://trac.webkit.org/changeset/235738>
Comment 12 WebKit Commit Bot 2018-09-06 09:01:14 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 13 Radar WebKit Bug Importer 2018-09-06 09:03:27 PDT 
<rdar://problem/44183440>
Comment 14 Myles C. Maxfield 2018-10-13 15:20:47 PDT 
Migrated to https://github.com/gpuweb/WHLSL/issues/87