| Summary: | [Payment Request] Update payment-request web platform tests | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andy Estes <aestes> | ||||||
| Component: | New Bugs | Assignee: | Andy Estes <aestes> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | achristensen, aestes, andersca, commit-queue, rniwa, sam, thorton, tsavell, webkit-bug-importer, wenson_hsieh, youennf | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Andy Estes
2018-08-27 10:02:08 PDT
Created attachment 348156 [details]
Patch
Created attachment 348157 [details]
Patch
Comment on attachment 348157 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348157&action=review > LayoutTests/imported/w3c/web-platform-tests/payment-request/idlharness.https.window-expected.txt:1 > +CONSOLE MESSAGE: line 8: ReferenceError: Can't find variable: idl_test Are we missing some other imports in common or resources? (In reply to youenn fablet from comment #3) > Comment on attachment 348157 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=348157&action=review > > > LayoutTests/imported/w3c/web-platform-tests/payment-request/idlharness.https.window-expected.txt:1 > > +CONSOLE MESSAGE: line 8: ReferenceError: Can't find variable: idl_test > > Are we missing some other imports in common or resources? Good question. I'll check! Comment on attachment 348157 [details] Patch Clearing flags on attachment: 348157 Committed r235390: <https://trac.webkit.org/changeset/235390> All reviewed patches have been landed. Closing bug. Moved test expectations from mac-wk2 to general in: https://trac.webkit.org/changeset/235441/webkit This should stop the failures across iOS. |