| Summary: | [Attachment Support] [WK2] Images copied from Mail message view paste with the wrong file name in compose | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||||||
| Component: | HTML Editing | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | aestes, bdakin, commit-queue, darin, mitz, thorton, webkit-bug-importer, wenson_hsieh | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Wenson Hsieh
2018-08-26 16:57:00 PDT
Created attachment 348105 [details] Depends on webkit.org/b/188903 Created attachment 348113 [details]
Rebase on trunk
Comment on attachment 348113 [details] Rebase on trunk View in context: https://bugs.webkit.org/attachment.cgi?id=348113&action=review > Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:1334 > + auto mainResource = adoptNS([[WebResource alloc] initWithData:markupData URL:[NSURL URLWithString:@"foo.html"] MIMEType:@"text/html" textEncodingName:@"utf-8" frameName:nil]); > + auto pngResource = adoptNS([[WebResource alloc] initWithData:testImageData() URL:[NSURL URLWithString:@"1.png"] MIMEType:@"image/png" textEncodingName:nil frameName:nil]); > + auto gifResource = adoptNS([[WebResource alloc] initWithData:testGIFData() URL:[NSURL URLWithString:@"2.gif"] MIMEType:@"image/gif" textEncodingName:nil frameName:nil]); > + auto archive = adoptNS([[WebArchive alloc] initWithMainResource:mainResource.get() subresources:@[ pngResource.get(), gifResource.get() ] subframeArchives:@[ ]]); We should start using ARC for our unit tests. Comment on attachment 348113 [details] Rebase on trunk View in context: https://bugs.webkit.org/attachment.cgi?id=348113&action=review >> Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:1334 >> + auto archive = adoptNS([[WebArchive alloc] initWithMainResource:mainResource.get() subresources:@[ pngResource.get(), gifResource.get() ] subframeArchives:@[ ]]); > > We should start using ARC for our unit tests. Noted! I suppose a good first step towards this is to add bridging casts as needed (in fact, there are several places in this file that directly cast NSStrings to CFStringRefs and vice versa). I'll be fixing these as I go, in subsequent patches. Created attachment 348148 [details]
Patch for landing
Comment on attachment 348148 [details] Patch for landing Clearing flags on attachment: 348148 Committed r235375: <https://trac.webkit.org/changeset/235375> |