Bug 188947

Summary:

[Apple Pay] Add a test for rendering Apple Pay buttons

Product:

WebKit

Reporter:

Andy Estes <aestes>

Component:

New Bugs

Assignee:

Andy Estes <aestes>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, commit-queue, ews-watchlist, rniwa, sam, simon.fraser, thorton, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews106 for mac-sierra-wk2	none
Patch	none

Andy Estes

Reported 2018-08-25 12:12:26 PDT

[Apple Pay] Add a test for rendering Apple Pay buttons

Attachments
Patch (40.83 KB, patch) 2018-08-25 12:15 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews106 for mac-sierra-wk2 (2.89 MB, application/zip) 2018-08-25 13:31 PDT, EWS Watchlist	no flags	Details
Patch (83.44 KB, patch) 2018-08-25 15:40 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Andy Estes

Comment 1 2018-08-25 12:15:22 PDT Comment hidden (obsolete)

Created attachment 348080 [details] Patch

EWS Watchlist

Comment 2 2018-08-25 13:31:26 PDT Comment hidden (obsolete)

Comment on attachment 348080 [details] Patch Attachment 348080 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/8982922 New failing tests: http/tests/ssl/applepay/ApplePayButton.html

EWS Watchlist

Comment 3 2018-08-25 13:31:28 PDT Comment hidden (obsolete)

Created attachment 348081 [details] Archive of layout-test-results from ews106 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

Andy Estes

Comment 4 2018-08-25 15:40:51 PDT

Created attachment 348084 [details] Patch

WebKit Commit Bot

Comment 5 2018-08-26 18:27:08 PDT

Comment on attachment 348084 [details] Patch Clearing flags on attachment: 348084 Committed r235341: <https://trac.webkit.org/changeset/235341>

WebKit Commit Bot

Comment 6 2018-08-26 18:27:09 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 7 2018-08-26 18:28:17 PDT

<rdar://problem/43739206>

Simon Fraser (smfr)

Comment 8 2018-08-27 13:12:44 PDT

Comment on attachment 348084 [details] Patch This test is useless. We don't run pixel tests. Also see LayoutTests/css/appearance-apple-pay-button.html

Andy Estes

Comment 9 2018-08-27 13:17:30 PDT

(In reply to Simon Fraser (smfr) from comment #8) > Comment on attachment 348084 [details] > Patch > > This test is useless. We don't run pixel tests. Also see > LayoutTests/css/appearance-apple-pay-button.html "Useless" seems like an overstatement. The metrics of the buttons can change, and I can run the pixel tests at my desk.

Note You need to log in before you can comment on or make changes to this bug.