Bug 188940

Summary: [WHLSL] Implement texture types
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: WebGPUAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 176199, 189202, 189225, 189226    
Attachments:
Description Flags
WIP
none
WIP
none
WIP
none
WIP
none
WIP
none
WIP
none
WIP
none
WIP
none
WIP
none
WIP
none
WIP
none
WIP
none
WIP
none
WIP
none
Can sample
none
Can sample
none
WIP
none
WIP
none
WIP
none
WIP
none
WIP
none
WIP
none
WIP
none
WIP
none
WIP
none
Cubemaps complete
none
Started gathering
none
Test gathering
none
Patch
none
Needs finishing touches
none
Needs tests for SampleCmpLevelZero
none
Patch dino: review+

Description Myles C. Maxfield 2018-08-24 19:19:59 PDT 
[WHLSL] Implement texture types
Comment 1 Myles C. Maxfield 2018-08-24 19:20:21 PDT 
Created attachment 348066 [details]
WIP
Comment 2 Myles C. Maxfield 2018-08-27 16:26:14 PDT 
We should make sure we test things like Texture2D<vector<float, 4>>
Comment 3 Myles C. Maxfield 2018-08-28 15:06:23 PDT 
Created attachment 348347 [details]
WIP
Comment 4 Myles C. Maxfield 2018-08-28 17:31:44 PDT 
Created attachment 348365 [details]
WIP
Comment 5 Myles C. Maxfield 2018-08-28 19:24:58 PDT 
Created attachment 348376 [details]
WIP
Comment 6 Myles C. Maxfield 2018-08-29 14:19:32 PDT 
Created attachment 348433 [details]
WIP
Comment 7 Myles C. Maxfield 2018-08-29 18:23:38 PDT 
Created attachment 348459 [details]
WIP
Comment 8 Myles C. Maxfield 2018-08-29 19:13:06 PDT 
Created attachment 348464 [details]
WIP
Comment 9 Myles C. Maxfield 2018-08-29 19:18:44 PDT 
Created attachment 348467 [details]
WIP
Comment 10 Myles C. Maxfield 2018-08-30 11:54:23 PDT 
Created attachment 348521 [details]
WIP
Comment 11 Myles C. Maxfield 2018-08-30 19:24:02 PDT 
Created attachment 348581 [details]
WIP
Comment 12 Myles C. Maxfield 2018-08-30 19:25:35 PDT 
Created attachment 348582 [details]
WIP
Comment 13 Myles C. Maxfield 2018-08-30 23:04:20 PDT 
Created attachment 348607 [details]
WIP
Comment 14 Myles C. Maxfield 2018-08-31 12:08:27 PDT 
Created attachment 348661 [details]
WIP
Comment 15 Myles C. Maxfield 2018-08-31 17:22:11 PDT 
Created attachment 348687 [details]
WIP
Comment 16 Myles C. Maxfield 2018-08-31 18:25:38 PDT 
Created attachment 348695 [details]
Can sample
Comment 17 Myles C. Maxfield 2018-08-31 19:42:10 PDT 
Created attachment 348698 [details]
Can sample
Comment 18 Myles C. Maxfield 2018-08-31 22:02:49 PDT 
Created attachment 348705 [details]
WIP
Comment 19 Myles C. Maxfield 2018-09-01 14:03:27 PDT 
Created attachment 348717 [details]
WIP
Comment 20 Myles C. Maxfield 2018-09-01 15:18:48 PDT 
Created attachment 348718 [details]
WIP
Comment 21 Myles C. Maxfield 2018-09-01 18:13:32 PDT 
Created attachment 348723 [details]
WIP
Comment 22 Myles C. Maxfield 2018-09-01 19:36:01 PDT 
Created attachment 348724 [details]
WIP
Comment 23 Myles C. Maxfield 2018-09-01 22:28:48 PDT 
Created attachment 348726 [details]
WIP
Comment 24 Myles C. Maxfield 2018-09-01 22:40:39 PDT 
Created attachment 348727 [details]
WIP
Comment 25 Myles C. Maxfield 2018-09-02 17:03:34 PDT 
Created attachment 348752 [details]
WIP
Comment 26 Myles C. Maxfield 2018-09-02 22:58:10 PDT 
Created attachment 348758 [details]
WIP
Comment 27 Myles C. Maxfield 2018-09-03 09:20:22 PDT 
Created attachment 348775 [details]
Cubemaps complete
Comment 28 Myles C. Maxfield 2018-09-03 15:23:56 PDT 
Created attachment 348791 [details]
Started gathering
Comment 29 Myles C. Maxfield 2018-09-03 17:06:15 PDT 
Created attachment 348797 [details]
Test gathering
Comment 30 Myles C. Maxfield 2018-09-03 17:33:39 PDT 
Created attachment 348798 [details]
Patch
Comment 31 Myles C. Maxfield 2018-09-03 19:51:49 PDT 
Created attachment 348800 [details]
Needs finishing touches
Comment 32 Myles C. Maxfield 2018-09-03 19:56:42 PDT 
Created attachment 348801 [details]
Needs tests for SampleCmpLevelZero
Comment 33 Myles C. Maxfield 2018-09-03 21:39:02 PDT 
Created attachment 348804 [details]
Patch
Comment 34 Dean Jackson 2018-09-04 11:31:25 PDT 
Comment on attachment 348804 [details]
Patch

rs=me
Comment 35 Myles C. Maxfield 2018-09-04 14:18:30 PDT 
Committed r235635: <https://trac.webkit.org/changeset/235635>
Comment 36 Radar WebKit Bug Importer 2018-09-04 14:19:20 PDT 
<rdar://problem/44112106>
Comment 37 Myles C. Maxfield 2018-09-04 14:42:07 PDT 
Committed r235642: <https://trac.webkit.org/changeset/235642>
Comment 38 Myles C. Maxfield 2018-10-13 19:13:46 PDT 
Migrated to https://github.com/gpuweb/WHLSL/issues/89