| Summary: | Check for null renderer in canBeScrolledIntoView | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Don Olmstead <don.olmstead> | ||||||
| Component: | WebCore Misc. | Assignee: | Don Olmstead <don.olmstead> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cdumez, commit-queue, darin, mcatanzaro, simon.fraser, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Don Olmstead
2018-08-24 15:46:06 PDT
Adding the following in the for loop fixes the problem. + if (UNLIKELY(!parentNode->renderer())) + continue; Its EOD here so if nobody gets to this by Monday I'll just throw together a patch with the layout test in it. Created attachment 348361 [details]
Patch
Port of the chromium fix
Comment on attachment 348361 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348361&action=review > Source/WebCore/page/SpatialNavigation.cpp:708 > + if (UNLIKELY(!parentNode->renderer())) The UNLIKELY() seems unnecessary. Created attachment 348371 [details]
Patch
Address review comments
Comment on attachment 348371 [details] Patch Clearing flags on attachment: 348371 Committed r235457: <https://trac.webkit.org/changeset/235457> All reviewed patches have been landed. Closing bug. |