| Summary: | Improve unified source generator script logging and error messages | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||
| Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ggaren, keith_miller, simon.fraser, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Tim Horton
2018-08-24 14:44:01 PDT
Created attachment 348040 [details]
Patch
Comment on attachment 348040 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348040&action=review > Source/WTF/ChangeLog:8 > + * Scripts/generate-unified-source-bundles.rb: Why isn't this in Tools/Scripts? > Source/WTF/Scripts/generate-unified-source-bundles.rb:306 > +# Add trailing semicolon since CMake dislikes not having it. Maybe just # Add trailing semicolon for CMake (In reply to Simon Fraser (smfr) from comment #2) > Comment on attachment 348040 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=348040&action=review > > > Source/WTF/ChangeLog:8 > > + * Scripts/generate-unified-source-bundles.rb: > > Why isn't this in Tools/Scripts? Scripts that are used at build time can't be in Tools/Scripts because that's not available for Apple production builds (because each Source/ subdirectory is built separately and without access to the others). > > Source/WTF/Scripts/generate-unified-source-bundles.rb:306 > > +# Add trailing semicolon since CMake dislikes not having it. > > Maybe just # Add trailing semicolon for CMake Sure. |