| Summary: | YARR: Update UCS canonicalization tables for Unicode 11 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Saboff <msaboff> | ||||
| Component: | JavaScriptCore | Assignee: | Michael Saboff <msaboff> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, ews-watchlist, keith_miller, mark.lam, saam, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Michael Saboff
2018-08-24 13:30:12 PDT
Created attachment 348036 [details]
Patch
Attachment 348036 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/yarr/YarrCanonicalizeUCS2.cpp:57: UCS2_CANONICALIZATION_SETS is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/yarr/YarrCanonicalizeUCS2.cpp:84: UCS2_CANONICALIZATION_RANGES is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
Total errors found: 2 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 348036 [details]
Patch
rs=me.
Comment on attachment 348036 [details] Patch Clearing flags on attachment: 348036 Committed r235333: <https://trac.webkit.org/changeset/235333> All reviewed patches have been landed. Closing bug. |