Bug 188926

Summary: Using Touch Bar to scrub video on Youtube results in video playback freeze
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Jer Noble 2018-08-24 12:36:26 PDT
Using Touch Bar to scrub video on Youtube results in video playback freeze
Comment 1 Jer Noble 2018-08-24 12:37:00 PDT
<rdar://42781297>
Comment 2 Jer Noble 2018-08-24 12:56:06 PDT
Created attachment 348035 [details]
Patch
Comment 3 Eric Carlson 2018-08-24 13:16:32 PDT
Comment on attachment 348035 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348035&action=review

> Source/WebCore/ChangeLog:12
> +        results in a round-trip between `float in -> MediaTime -> float out` where in != out, we will wait forever for
> +        time jump observer to fire. Break the cycle by comparing m_lastSeekTime to the synchronizerTime only after

Nit: ... wait for *the* time jump observer ...
Comment 4 Jer Noble 2018-08-24 14:02:57 PDT
Created attachment 348039 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2018-08-24 14:40:59 PDT
Comment on attachment 348039 [details]
Patch for landing

Clearing flags on attachment: 348039

Committed r235334: <https://trac.webkit.org/changeset/235334>
Comment 6 WebKit Commit Bot 2018-08-24 14:41:00 PDT
All reviewed patches have been landed.  Closing bug.