| Summary: | [Curl] Match the interface used in NetworkDataTask and ResourceHandle. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Basuke Suzuki <Basuke.Suzuki> | ||||
| Component: | Platform | Assignee: | Basuke Suzuki <Basuke.Suzuki> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | achristensen, Basuke.Suzuki, commit-queue, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Basuke Suzuki
2018-08-24 11:10:23 PDT
Created attachment 348028 [details]
PATCH
Comment on attachment 348028 [details] PATCH View in context: https://bugs.webkit.org/attachment.cgi?id=348028&action=review > Source/WebKit/NetworkProcess/curl/NetworkDataTaskCurl.h:54 > + ReusedRequest This enum class is the one used in ResourceHandle. This one is more meaningful than ShouldProcess which is just a boolean equivalent. Comment on attachment 348028 [details]
PATCH
This is nice. I think it would be even nicer to remove this new/reused nonsense unless there is a measurable performance improvement to make the code complexity and risk of forgetting to update things worth it.
Comment on attachment 348028 [details]
PATCH
Thanks for r+. We think about removing this flag. I remember this relate to not only cookie, but diskcache on ResourceHandle.
Comment on attachment 348028 [details] PATCH Clearing flags on attachment: 348028 Committed r235326: <https://trac.webkit.org/changeset/235326> All reviewed patches have been landed. Closing bug. |