| Summary: | [LFC][Floating] Simplify FloatingState::FloatItem class | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
zalan
2018-08-23 19:09:28 PDT
Created attachment 347984 [details]
Patch
Comment on attachment 347984 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=347984&action=review > Source/WebCore/layout/floats/FloatingContext.cpp:68 > + const FloatingState::FloatItem* left() const; > + const FloatingState::FloatItem* right() const; "FloatItem" is a weird name. "Item" doesn't tell me what type it is, and we don't use "item" in other rendering code. (In reply to Simon Fraser (smfr) from comment #2) > Comment on attachment 347984 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=347984&action=review > > > Source/WebCore/layout/floats/FloatingContext.cpp:68 > > + const FloatingState::FloatItem* left() const; > > + const FloatingState::FloatItem* right() const; > > "FloatItem" is a weird name. "Item" doesn't tell me what type it is, and we > don't use "item" in other rendering code. I am planning to rename it in an upcoming patch. Committed r235350: <https://trac.webkit.org/changeset/235350> |