Bug 188908

Summary:

[Curl] Implement deleteCookie()

Product:

WebKit

Reporter:

Basuke Suzuki <Basuke.Suzuki>

Component:

Platform

Assignee:

Basuke Suzuki <Basuke.Suzuki>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, Basuke.Suzuki, chris.reid, commit-queue, ews-watchlist, galpeter, Hironori.Fujii, joepeck, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
PATCH	none

Description Basuke Suzuki 2018-08-23 16:55:41 PDT

Delete cookie was not implemented.

Comment 1 Basuke Suzuki 2018-08-24 10:29:19 PDT

It is used from the web inspector.

Comment 2 Basuke Suzuki 2018-08-24 10:31:47 PDT

Created attachment 348020 [details]
PATCH

Comment 3 Fujii Hironori 2018-08-26 21:29:02 PDT

Comment on attachment 348020 [details]
PATCH

I think this is not right. NetworkStorageSession::deleteCookie
should delete cookies only in the storage session for private
browsing mode. But, I don't object to land this change.

Comment 4 WebKit Commit Bot 2018-08-26 21:55:16 PDT

Comment on attachment 348020 [details]
PATCH

Clearing flags on attachment: 348020

Committed r235351: <https://trac.webkit.org/changeset/235351>

Comment 5 WebKit Commit Bot 2018-08-26 21:55:18 PDT

All reviewed patches have been landed.  Closing bug.

Comment 6 Radar WebKit Bug Importer 2018-08-26 21:56:16 PDT

<rdar://problem/43742331>

Comment 7 Basuke Suzuki 2018-08-28 15:24:49 PDT

(In reply to Fujii Hironori from comment #3)
> Comment on attachment 348020 [details]
> PATCH
> 
> I think this is not right. NetworkStorageSession::deleteCookie
> should delete cookies only in the storage session for private
> browsing mode. But, I don't object to land this change.

I cannot get what you say. CookieJarCurlDatabase::deleteCookie() will be called with proper NetworkStorageSession object. It doesn't tightly connected to private mode, but it may happen on default session. The method itself will be called from web inspector to delete specific cookie. These are my understanding.

Comment 8 Fujii Hironori 2018-08-29 20:02:02 PDT

Curl port should suport multiple cookie storages for private browsing mode as well as other ports does.
NetworkStorageSession::deleteCookie should delete cookies only in its cookie storage.

Comment 9 Basuke Suzuki 2018-08-30 10:41:16 PDT

Got it. Your point is that every network storage session shares same cookie jar db. We should fix that. Also we need a reference implementation of private mode in MiniBrowser.