| Summary: | Add new _webViewRequestPointerLock SPI with a completionHandler | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aestes, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Alex Christensen
2018-08-23 16:09:46 PDT
Created attachment 347968 [details]
Patch
Comment on attachment 347968 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=347968&action=review > Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:100 > - (void)_webViewRequestPointerLock:(WKWebView *)webView WK_API_AVAILABLE(macosx(10.12.3)); Should we deprecate this? > Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:101 > +- (void)_webViewRequestPointerLock:(WKWebView *)webView completionHandler:(void (^)(BOOL))completionHandler WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA)); _webViewDidRequestPointerLock? > Source/WebKit/UIProcess/Cocoa/UIDelegate.mm:1179 > + if (m_uiDelegate.m_delegateMethods.webViewRequestPointerLock) > + [static_cast<id <WKUIDelegatePrivate>>(delegate) _webViewRequestPointerLock:m_uiDelegate.m_webView]; I'd early return here and un-indent the rest. |