Bug 188900

Summary: Move vmEntryGlobalObject() to VM from CallFrame.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, fpizlo, keith_miller, mkwst, msaboff, rmorisset, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch.
none
proposed patch w/ GTK build fix. msaboff: review+

Mark Lam
Reported 2018-08-23 13:35:32 PDT
It doesn't really belong in CallFrame to begin with.
Attachments
proposed patch. (39.81 KB, patch)
2018-08-23 14:42 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
proposed patch w/ GTK build fix. (39.81 KB, patch)
2018-08-23 15:01 PDT, Mark Lam 		msaboff: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-08-23 13:36:00 PDT
<rdar://problem/43655753>
Mark Lam
Comment 2 2018-08-23 14:42:06 PDT
Created attachment 347955 [details] proposed patch.
Mark Lam
Comment 3 2018-08-23 15:01:53 PDT
Created attachment 347958 [details] proposed patch w/ GTK build fix.
Michael Saboff
Comment 4 2018-08-23 15:51:36 PDT
Comment on attachment 347958 [details] proposed patch w/ GTK build fix. r=me
Mark Lam
Comment 5 2018-08-23 15:57:48 PDT
Thanks for the review. Landed in r235254: <http://trac.webkit.org/r235254>.
Note You need to log in before you can comment on or make changes to this bug.