Bug 188898

Summary: [iOS] Test editing/undo/replace-text-in-node-preserving-markers-crash.html crashes
Product: WebKit Reporter: Daniel Bates <dbates>
Component: WebCore Misc.Assignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: realdawei, rniwa, ryanhaddad, simon.fraser, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar, LayoutTestFailure, MakingBotsRed
Version: WebKit Nightly Build   
Hardware: iPhone / iPad   
OS: Unspecified   
Attachments:
Description Flags
[WK1] Stacktrace
none
Patch none

Description Daniel Bates 2018-08-23 12:38:26 PDT 
Steps to reproduce:

Tools/Scripts/run-webkit-tests -1 --debug --no-timeout --no-retry-failures --no-sample-on-timeout --child-processes 1 --iterations 10 --batch-size 10000 --ios-simulator editing/undo/replace-text-in-node-preserving-markers-crash.html

Then the test will crash.

Following <https://trac.webkit.org/changeset/235149> (bug #188800) you can also reproduce this crash in WebKit2, omitting the -1 in the above command line, run:

Tools/Scripts/run-webkit-tests --debug --no-timeout --no-retry-failures --no-sample-on-timeout --child-processes 1 --iterations 10 --batch-size 10000 --ios-simulator editing/undo/replace-text-in-node-preserving-markers-crash.html
Comment 1 Daniel Bates 2018-08-23 12:39:35 PDT 
Created attachment 347947 [details]
[WK1] Stacktrace

Stacktrace when running the test in WebKit1.
Comment 2 Daniel Bates 2018-08-23 15:07:17 PDT 
Created attachment 347959 [details]
Patch
Comment 3 Simon Fraser (smfr) 2018-08-23 15:41:05 PDT 
Comment on attachment 347959 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347959&action=review

> Source/WebCore/dom/DocumentMarker.h:129
>  #if PLATFORM(IOS)

I wonder if we really need these #ifdefs. Can we just stub things out on macOS?
Comment 4 Daniel Bates 2018-08-23 15:59:32 PDT 
Comment on attachment 347959 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347959&action=review

>> Source/WebCore/dom/DocumentMarker.h:129
>>  #if PLATFORM(IOS)
> 
> I wonder if we really need these #ifdefs. Can we just stub things out on macOS?

Yes, but I resisted the temptation to do that now.
Comment 5 Daniel Bates 2018-08-23 16:20:04 PDT 
Comment on attachment 347959 [details]
Patch

Clearing flags on attachment: 347959

Committed r235256: <https://trac.webkit.org/changeset/235256>
Comment 6 Daniel Bates 2018-08-23 16:20:06 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-08-23 16:21:17 PDT 
<rdar://problem/43663322>