| Summary: | [CoordGraphics] Remove the remaining CoordinatedGraphicsLayerState cruft | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||||
| Component: | New Bugs | Assignee: | Zan Dobersek <zan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cgarcia, ews-watchlist, magomez, mcatanzaro, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=188916 | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 187385 | ||||||||
| Attachments: |
|
||||||||
|
Description
Zan Dobersek
2018-08-23 00:21:49 PDT
Created attachment 347915 [details]
Patch
Attachment 347915 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:114: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4]
Total errors found: 1 in 9 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 347916 [details]
Patch
Attachment 347916 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:114: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4]
Total errors found: 1 in 9 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 347916 [details] Patch Clearing flags on attachment: 347916 Committed r235221: <https://trac.webkit.org/changeset/235221> All reviewed patches have been landed. Closing bug. I think you need to fix this: (In reply to Build Bot from comment #4) > ERROR: > Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer. > h:114: Inline functions should not be in classes annotated with > WEBCORE_EXPORT. Remove the macro from the class and apply it to each > appropriate method, or move the inline function definition out-of-line. > [build/webcore_export] [4] > Total errors found: 1 in 9 files (In reply to Michael Catanzaro from comment #8) > I think you need to fix this: > > (In reply to Build Bot from comment #4) > > ERROR: > > Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer. > > h:114: Inline functions should not be in classes annotated with > > WEBCORE_EXPORT. Remove the macro from the class and apply it to each > > appropriate method, or move the inline function definition out-of-line. > > [build/webcore_export] [4] > > Total errors found: 1 in 9 files Bug #188916. |