Bug 188875

Summary: TypedArray's [[DefineOwnProperty]] is incorrect with partial descriptors
Product: WebKit Reporter: isol2
Component: JavaScriptCoreAssignee: Alexey Shvayka <ashvayka>
Status: RESOLVED FIXED    
Severity: Minor CC: ashvayka, ews-watchlist, fpizlo, keith_miller, mark.lam, msaboff, ross.kirsling, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Description isol2 2018-08-22 18:12:24 PDT 
Hi everyone,

there is an inconsistency when we try to seal a TypedArray object.

version: 235121
OS: Ubuntu 16.04 x64

Steps to reproduce
let ta = new Int32Array(10);
Object.seal(ta);

Actual results:
TypeError: Attempting to store non-enumerable or non-writable property on a typed array at index: 0

Expected results:
pass without failures


V8, Chakra and SpiderMonkey works as expected.


cinfuzz
Comment 1 Ross Kirsling 2020-04-02 20:57:08 PDT 
Might be the same cause as this failure:
https://test262.report/browse/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/conversion-operation.js
Comment 2 Alexey Shvayka 2020-04-02 20:58:13 PDT 
Created attachment 395342 [details]
Patch
Comment 3 Ross Kirsling 2020-04-02 21:00:51 PDT 
(In reply to Ross Kirsling from comment #1)
> Might be the same cause as this failure:
> https://test262.report/browse/built-ins/TypedArrayConstructors/internals/
> DefineOwnProperty/conversion-operation.js

Oh, heh, I didn't notice the date of the original comment... 🤦‍♂️
Comment 4 Ross Kirsling 2020-04-02 21:02:38 PDT 
Comment on attachment 395342 [details]
Patch

r=me pending EWS
Comment 5 EWS 2020-04-02 22:57:23 PDT 
Committed r259444: <https://trac.webkit.org/changeset/259444>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395342 [details].
Comment 6 Radar WebKit Bug Importer 2020-04-02 22:58:13 PDT 
<rdar://problem/61245087>