| Summary: | [WHLSL] Add more functions to the standard library | ||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||||||||||||||||||||||||||||||||||||
| Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||||||||||||||||||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||||||||||||||||||||||
| Severity: | Normal | CC: | commit-queue, dino, fpizlo, rmorisset, tdenney, webkit-bug-importer | ||||||||||||||||||||||||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||||||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||||||||||||||||||||||
| Bug Depends on: | |||||||||||||||||||||||||||||||||||||||||||
| Bug Blocks: | 176199 | ||||||||||||||||||||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||||||||||||||||||||
|
Description
Myles C. Maxfield
2018-08-22 17:45:44 PDT
Created attachment 347885 [details]
WIP
Created attachment 347895 [details]
WIP
Created attachment 347901 [details]
WIP
Created attachment 347935 [details]
Matrix types compile
Created attachment 347936 [details]
Matrix types compile
Created attachment 347963 [details]
Patch
*** Bug 188685 has been marked as a duplicate of this bug. *** Created attachment 347980 [details]
WIP
Created attachment 347993 [details]
WIP
Created attachment 348011 [details]
Patch
Created attachment 348051 [details]
Patch
Created attachment 348053 [details]
Patch
Created attachment 348078 [details]
WIP
Created attachment 348087 [details]
Patch
Created attachment 348088 [details]
Patch
Created attachment 348091 [details]
Patch
Created attachment 348208 [details]
Patch
Created attachment 348224 [details]
Patch
R=me. I had a hard time setting r+, presumably due to the size of the patch. One bit of feedback: you could have written JS code that loops over types and operators to generate the repetitive WHLSL code. Particularly for the swizzle operators. Created attachment 348413 [details]
Patch for committing
(In reply to Filip Pizlo from comment #19) > R=me. I had a hard time setting r+, presumably due to the size of the patch. > > One bit of feedback: you could have written JS code that loops over types > and operators to generate the repetitive WHLSL code. Particularly for the > swizzle operators. Done. Doing this reduces the patch size from 1.63MB to 222KB. Created attachment 348415 [details]
Patch for committing
Comment on attachment 348415 [details] Patch for committing Clearing flags on attachment: 348415 Committed r235469: <https://trac.webkit.org/changeset/235469> All reviewed patches have been landed. Closing bug. *** Bug 177645 has been marked as a duplicate of this bug. *** *** Bug 188489 has been marked as a duplicate of this bug. *** Migrated to https://github.com/gpuweb/WHLSL/issues/91 |