Bug 188858

Summary: Don't use WTF_CPU_MIPS when building for mips64
Product: WebKit Reporter: Alberto Garcia <berto>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, cgarcia, clopez, lforschler, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mcatanzaro: review+

Alberto Garcia
Reported 2018-08-22 12:52:09 PDT
We want that the build system detects automatically when to enable the JIT, but we can't do it with mips64 as we do it for mips, since the former is not supported and results on a build failure: In file included from Source/JavaScriptCore/jit/GPRInfo.h:28, from Source/JavaScriptCore/interpreter/VMEntryRecord.h:28, from Source/JavaScriptCore/interpreter/StackVisitor.h:29, from Source/JavaScriptCore/interpreter/CallFrame.h:29, from Source/JavaScriptCore/runtime/ClassInfo.h:25, from Source/JavaScriptCore/runtime/Structure.h:28, from Source/JavaScriptCore/bytecode/ArrayProfile.h:29, from Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp:28: Source/JavaScriptCore/assembler/MacroAssembler.h:69:2: error: #error "The MacroAssembler is not supported on this platform." There's a separate WTF_CPU_MIPS64 for this architecture.
Attachments
Patch (1.05 KB, patch)
2018-08-22 12:54 PDT, Alberto Garcia 		mcatanzaro: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alberto Garcia
Comment 1 2018-08-22 12:54:21 PDT
Created attachment 347832 [details] Patch
Michael Catanzaro
Comment 2 2018-08-22 13:22:31 PDT
Comment on attachment 347832 [details] Patch * Reviewed all the checks in existing CMake code * Verified this matches WTF's WTF_CPU_MIPS64 macro * Good!
Alberto Garcia
Comment 3 2018-08-22 13:27:32 PDT
Committed r235194: <https://trac.webkit.org/changeset/235194>
Radar WebKit Bug Importer
Comment 4 2018-08-22 13:29:05 PDT
<rdar://problem/43617883>
Note You need to log in before you can comment on or make changes to this bug.