| Summary: | Don't use WTF_CPU_MIPS when building for mips64 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alberto Garcia <berto> | ||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | berto, cgarcia, clopez, lforschler, mcatanzaro, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Other | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
Created attachment 347832 [details]
Patch
Comment on attachment 347832 [details]
Patch
* Reviewed all the checks in existing CMake code
* Verified this matches WTF's WTF_CPU_MIPS64 macro
* Good!
Committed r235194: <https://trac.webkit.org/changeset/235194> |
We want that the build system detects automatically when to enable the JIT, but we can't do it with mips64 as we do it for mips, since the former is not supported and results on a build failure: In file included from Source/JavaScriptCore/jit/GPRInfo.h:28, from Source/JavaScriptCore/interpreter/VMEntryRecord.h:28, from Source/JavaScriptCore/interpreter/StackVisitor.h:29, from Source/JavaScriptCore/interpreter/CallFrame.h:29, from Source/JavaScriptCore/runtime/ClassInfo.h:25, from Source/JavaScriptCore/runtime/Structure.h:28, from Source/JavaScriptCore/bytecode/ArrayProfile.h:29, from Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp:28: Source/JavaScriptCore/assembler/MacroAssembler.h:69:2: error: #error "The MacroAssembler is not supported on this platform." There's a separate WTF_CPU_MIPS64 for this architecture.