| Summary: | Move files in WebCore project to match Xcode folder structure | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
| Component: | WebCore Misc. | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aestes, bfulgham, commit-queue, ddkilzer, pvollan, thorton, webkit-bug-importer, wenson_hsieh | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Safari 10 | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 188754 | ||||||
| Attachments: |
|
||||||
|
Description
David Kilzer (:ddkilzer)
2018-08-22 09:30:33 PDT
This patch mostly consists of 6 file moves (and fixing 3 style warnings for WAKViewInternal.h): [master 4e8c3d6446f] Move files in WebCore project to match Xcode folder structure <https://webkit.org/b/188851> 11 files changed, 40 insertions(+), 11 deletions(-) rename Source/WebCore/{ => Scripts}/LocalizableStrings.pm (100%) rename Source/WebCore/{ => Scripts}/extract-localizable-strings.pl (100%) rename Source/WebCore/platform/audio/{ => cocoa}/WebAudioBufferList.cpp (100%) rename Source/WebCore/platform/audio/{ => cocoa}/WebAudioBufferList.h (100%) rename Source/WebCore/platform/graphics/avfoundation/{ => objc}/MediaSampleAVFObjC.h (100%) rename Source/WebCore/platform/{ => ios/wak}/WAKViewInternal.h (90%) Created attachment 347810 [details]
Patch v1
(In reply to David Kilzer (:ddkilzer) from comment #1) > This patch mostly consists of 6 file moves (and fixing 3 style warnings for > WAKViewInternal.h): > > [master 4e8c3d6446f] Move files in WebCore project to match Xcode folder > structure <https://webkit.org/b/188851> > 11 files changed, 40 insertions(+), 11 deletions(-) > rename Source/WebCore/{ => Scripts}/LocalizableStrings.pm (100%) > rename Source/WebCore/{ => Scripts}/extract-localizable-strings.pl (100%) > rename Source/WebCore/platform/audio/{ => cocoa}/WebAudioBufferList.cpp > (100%) > rename Source/WebCore/platform/audio/{ => cocoa}/WebAudioBufferList.h (100%) > rename Source/WebCore/platform/graphics/avfoundation/{ => > objc}/MediaSampleAVFObjC.h (100%) > rename Source/WebCore/platform/{ => ios/wak}/WAKViewInternal.h (90%) This is the WAKViewInternal.h change: diff --git a/Source/WebCore/platform/WAKViewInternal.h b/Source/WebCore/platform/ios/wak/WAKViewInternal.h similarity index 90% rename from Source/WebCore/platform/WAKViewInternal.h rename to Source/WebCore/platform/ios/wak/WAKViewInternal.h index 94f98dd299c..cad06283719 100644 --- a/Source/WebCore/platform/WAKViewInternal.h +++ b/Source/WebCore/platform/ios/wak/WAKViewInternal.h @@ -28,13 +28,15 @@ #import "WAKView.h" #import "WKView.h" -@interface WAKView () { +@interface WAKView () +{ @package WKViewContext viewContext; WKViewRef viewRef; - NSMutableSet *subviewReferences; // This array is only used to keep WAKViews alive. - // The actual subviews are maintained by the WKView. + // This array is only used to keep WAKViews alive. + // The actual subviews are maintained by the WKView. + NSMutableSet *subviewReferences; BOOL _isHidden; BOOL _drawsOwnDescendants; Comment on attachment 347810 [details] Patch v1 Clearing flags on attachment: 347810 Committed r235190: <https://trac.webkit.org/changeset/235190> All reviewed patches have been landed. Closing bug. |