Bug 188838

Summary: [CoordGraphics] Remove the 'previous backing store' logic
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cadubentzen, cmarcelo, commit-queue, ews-watchlist, kondapallykalyan, luiz, magomez, mcatanzaro, noam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=188693
Attachments:
Description Flags
Patch
none
Patch none

Description Zan Dobersek 2018-08-22 04:49:03 PDT 
In CoordinatedGraphicsLayer, the current backing store is sometimes kept around after it's removed, in order to keep the tile data contained there alive for the near future. I think this is a remnant from the cross-process CoordinatedGraphics usage that's not obsolete. The previous backing store management should thus probably be possible to remove.

This report originates from bug #188693.
Comment 1 Miguel Gomez 2018-08-30 01:09:23 PDT 
I always wondered what was the previous backingStore about and whether we could remove it, but never had time to check it. I'll add this to my list.
Comment 2 Carlos Bentzen 2018-10-03 06:59:45 PDT 
Created attachment 351516 [details]
Patch
Comment 3 Miguel Gomez 2018-10-04 00:33:32 PDT 
Comment on attachment 351516 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351516&action=review

> Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:872
>          m_pendingContentsScaleAdjustment = false;

You changed the logic here. m_pendingContentsScaleAdjustment must always be set to false if it was true, not only when the three conditions are met.
Comment 4 Carlos Bentzen 2018-10-04 05:51:58 PDT 
(In reply to Miguel Gomez from comment #3)
> Comment on attachment 351516 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=351516&action=review
> 
> > Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:872
> >          m_pendingContentsScaleAdjustment = false;
> 
> You changed the logic here. m_pendingContentsScaleAdjustment must always be
> set to false if it was true, not only when the three conditions are met.

True.

Thanks for the review!
Comment 5 Carlos Bentzen 2018-10-04 05:53:10 PDT 
Created attachment 351594 [details]
Patch
Comment 6 WebKit Commit Bot 2018-10-09 12:23:29 PDT 
Comment on attachment 351594 [details]
Patch

Clearing flags on attachment: 351594

Committed r236974: <https://trac.webkit.org/changeset/236974>
Comment 7 WebKit Commit Bot 2018-10-09 12:23:31 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-10-09 12:24:27 PDT 
<rdar://problem/45135211>