| Summary: | Spelling dots do not scale with page on iOS; share spelling dot painting code between Mac and iOS | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||||||||||
| Component: | WebCore Misc. | Assignee: | Daniel Bates <dbates> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | mmaxfield, simon.fraser, webkit-bug-importer, wenson_hsieh | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Local Build | ||||||||||||||
| Hardware: | iPhone / iPad | ||||||||||||||
| OS: | iOS 11 | ||||||||||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=188762 https://bugs.webkit.org/show_bug.cgi?id=188861 |
||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Daniel Bates
2018-08-21 16:41:00 PDT
Another benefit is that we get to remove a lot of code :P Created attachment 347731 [details]
Patch
An example of a rendering artifact when painting the bitmap dots on iOS can be see in attachment #347552 [details] (bug #188762). Created attachment 347733 [details]
Patch
Comment on attachment 347731 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=347731&action=review > Source/WebCore/platform/graphics/cocoa/GraphicsContextCocoa.mm:220 > + // Cocoa platform use the theme to paint the platform document markers. Uses the theme? (In reply to Simon Fraser (smfr) from comment #5) > Comment on attachment 347731 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=347731&action=review > > > Source/WebCore/platform/graphics/cocoa/GraphicsContextCocoa.mm:220 > > + // Cocoa platform use the theme to paint the platform document markers. > > Uses the theme? Maybe "Cocoa platforms use RenderTheme::drawLineForDocumentMarker() to paint the platform document markers."? Created attachment 347746 [details] Patch Updated code comment per comment 6. Removed more codez. (In reply to Daniel Bates from comment #0) > A side benefit of sharing more code between Mac and iOS is that this will > fix rendering artifacts when painting spelling dots on iOS when the page is > zoomed. This issue is tracked in <rdar://problem/15966403>. Created attachment 347809 [details]
Patch
Comment on attachment 347809 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=347809&action=review > Source/WebCore/rendering/RenderThemeCocoa.mm:29 > #if ENABLE(APPLE_PAY) Er, why are all these #includes under ENABLE(APPLE_PAY)? I think you'll have to move out those you need for drawLineForDocumentMarker(). Comment on attachment 347809 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=347809&action=review >> Source/WebCore/rendering/RenderThemeCocoa.mm:29 >> #if ENABLE(APPLE_PAY) > > Er, why are all these #includes under ENABLE(APPLE_PAY)? I think you'll have to move out those you need for drawLineForDocumentMarker(). Will fix before landing. Created attachment 347972 [details]
For landing
Committed r235378: <https://trac.webkit.org/changeset/235378> *** Bug 135666 has been marked as a duplicate of this bug. *** |