Bug 188818

Summary: Cleanup: Remove unused file-local static variable from TextCheckerIOS.mm
Product: WebKit Reporter: Daniel Bates <dbates>
Component: WebKit Misc.Assignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: simon.fraser, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Description Daniel Bates 2018-08-21 14:53:03 PDT 
Remove the file-local static variable, smartInsertDeleteEnabled, as it is unused and increases binary size.

$ nm -a WebKitBuild/Debug-iphonesimulator/WebKit.framework/WebKit | grep smartInsertDeleteEnabled
...
00000000017f0970 b __ZN6WebKitL24smartInsertDeleteEnabledE
Comment 1 Daniel Bates 2018-08-21 14:54:17 PDT 
Created attachment 347704 [details]
Patch
Comment 2 Daniel Bates 2018-08-21 17:49:40 PDT 
Comment on attachment 347704 [details]
Patch

Clearing flags on attachment: 347704

Committed r235150: <https://trac.webkit.org/changeset/235150>
Comment 3 Daniel Bates 2018-08-21 17:49:43 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-08-21 17:50:17 PDT 
<rdar://problem/43585928>
Comment 5 Daniel Bates 2018-08-22 09:44:19 PDT 
(In reply to Daniel Bates from comment #0)
> Remove the file-local static variable, smartInsertDeleteEnabled, as it is
> unused and increases binary size.

Disregard the remark about increasing binary size.