| Summary: | [MSVC] Stop disabling /O2 features. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ross Kirsling <ross.kirsling> | ||||||||
| Component: | New Bugs | Assignee: | Ross Kirsling <ross.kirsling> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | achristensen, bfulgham, commit-queue, don.olmstead, ews-watchlist, Hironori.Fujii, jfbastien, pvollan, webkit-bug-importer, ysuzuki | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=187737 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Ross Kirsling
2018-08-21 13:43:56 PDT
Created attachment 347686 [details]
Patch
/O2 should equate to all of these: /Og /Oi /Ot /Oy /Ob2 /Gs /GF /Gy But we have a few disabled: /Oy- /GF- /Gy- These appear to have been necessary for AppleWin back at the time of https://trac.webkit.org/changeset/190361. But WinCairo doesn't seem to need to disable these optimizations, and I'm hoping the same is true for AppleWin. This patch fixes bug 187737 as a side effect. Given that the AppleWin build passed and this doesn't seem to be making the existing test failures any worse, I'd say we're safe as hoped! :D Comment on attachment 347686 [details] Patch Attachment 347686 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8943713 New failing tests: http/tests/security/local-video-source-from-remote.html Created attachment 347793 [details]
Archive of layout-test-results from ews202 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit
I seem to remember that JSC needs the frame pointer. Do you see any JSC test regressions when applying this patch? (In reply to Per Arne Vollan from comment #6) > I seem to remember that JSC needs the frame pointer. Do you see any JSC test > regressions when applying this patch? Ahh -- I was hoping any issues would be made evident by Layout/API/Bindings/Built-ins tests, as we've yet to fully stabilize our JSC testing for WinCairo. (Actually in the past, JIT issues have often been reproable just by running MiniBrowser on a couple of pages.) If there are certain edge cases that require run-javascriptcore-tests to reliably encounter, would it be possible to have somebody test this with AppleWin? Otherwise I suppose we could try it, keep a close eye on the AppleWin Debug Tests bot, and revert that part if things go unexpectedly south? Created attachment 347838 [details]
Patch
Comment on attachment 347838 [details]
Patch
R=me. Before landing, please check that changing these settings does not make the WebKit build significantly slower (both debug and release).
Comment on attachment 347838 [details] Patch Clearing flags on attachment: 347838 Committed r235203: <https://trac.webkit.org/changeset/235203> All reviewed patches have been landed. Closing bug. |