Bug 188806

Summary:

Web Inspector: Rulers.svg is missing

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none

Description Joseph Pecoraro 2018-08-21 13:14:11 PDT

Inspecting Production Web Inspector on macOS:

    [Error] Failed to load resource: The requested URL was not found on this server. (Rulers.svg, line 0)

Sure enough it appears to be missing. Was missed in:
https://bugs.webkit.org/show_bug.cgi?id=185644
https://trac.webkit.org/changeset/231881

Comment 1 Radar WebKit Bug Importer 2018-08-21 13:14:35 PDT

<rdar://problem/43574273>

Comment 2 Joseph Pecoraro 2018-08-21 13:15:28 PDT

Created attachment 347675 [details]
[PATCH] Proposed Fix

Comment 3 Devin Rousso 2018-08-21 13:32:06 PDT

Comment on attachment 347675 [details]
[PATCH] Proposed Fix

r=me.  Oops.  I don't know how I didn't upload that 🤔

Comment 4 WebKit Commit Bot 2018-08-21 14:00:37 PDT

Comment on attachment 347675 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 347675

Committed r235134: <https://trac.webkit.org/changeset/235134>

Comment 5 WebKit Commit Bot 2018-08-21 14:00:39 PDT

All reviewed patches have been landed.  Closing bug.